fix(schema) service host cannot have port #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/service-host
branch
from
0bf51ca to
405ebac
Compare
### Summary PR #5102 changed service entity where it added optional `port` to `service.host`. This is not actually used, and is wrong as the service also has `service.port` for that. Thus this PR returns that back to original, that is `service.host` cannot contain `port`.
bungle
force-pushed
the
fix/service-host
branch
from
405ebac to
c5c7773
Compare
hishamhm
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #5102 changed service entity where it added optional
porttoservice.host. This is not actually used, and is wrong as the service also hasservice.portfor that. Thus this PR returns that back to original, that isservice.hostcannot containport.