-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spin out and upgrade Lambda plugin #5083
Conversation
CI fails on a LuaRocks error;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these lines from the rockspec:
Lines 348 to 350 in fe3088a
["kong.plugins.aws-lambda.handler"] = "kong/plugins/aws-lambda/handler.lua", | |
["kong.plugins.aws-lambda.schema"] = "kong/plugins/aws-lambda/schema.lua", | |
["kong.plugins.aws-lambda.v4"] = "kong/plugins/aws-lambda/v4.lua", |
make dev
in my clean Ubuntu machine. I think it makes sense since we're removing it from the codebase.
@murillopaula good catch! updated |
aws-lambda plugin now lives in its own repo. It also was upgraded with several new features. See changelog.
@Tieske rebase current 'next' branch to make travis happy |
had already done so, but needed a few job-restarts to finally pass |
@Tieske FYI the plugin's CI tests pass when pointing to your 'lambda' branch: Kong/kong-plugin-aws-lambda#7 |
Hi, I have approved this change on this repo. However, I believe that some work is needed on the new aws-lambda repo. In particular, these:
Seem to be missing. |
@kikito the changelog was updated (and merged), see Kong/kong-plugin-aws-lambda#9 |
aws-lambda plugin now lives in its own repo. It also was upgraded with several new features. See changelog.
aws-lambda plugin now lives in its own repo. It also was upgraded with several new features. See changelog.
aws-lambda plugin now lives in its own repo. It also was upgraded with several new features. See changelog.
The plugin now lives in its own repo.
New features (see changelog):
Note on versioning: the update was developed separately, hence the updates are in the changelog under
0.1.0
. After renaming the external plugin toaws-lambda
the version was bumped to3.0.0
to supersede the existing (internal Kong) version at2.0.0
.