Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin out and upgrade Lambda plugin #5083

Merged
merged 1 commit into from
Oct 8, 2019
Merged

spin out and upgrade Lambda plugin #5083

merged 1 commit into from
Oct 8, 2019

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Oct 2, 2019

The plugin now lives in its own repo.

New features (see changelog):

  • feat: if no credentiuals are provided, the plugin will automatically fetch EC2 or ECS credentials and use the AWS IAM roles retrieved for accessing the Lambda.
  • feat: new option awsgateway_compatible to make the serialized request compatible with the AWS gateway format, making the plugin a drop-in replacement
  • feat: new option skip_large_bodies to enable really large bodies (that have been cached to disk) to also be sent to the Lambda. Use with care!
  • feat: added the ability to connect to the Lambda through a proxy

Note on versioning: the update was developed separately, hence the updates are in the changelog under 0.1.0. After renaming the external plugin to aws-lambda the version was bumped to 3.0.0 to supersede the existing (internal Kong) version at 2.0.0.

@Tieske
Copy link
Member Author

Tieske commented Oct 2, 2019

CI fails on a LuaRocks error;

Error: Build error: Failed installing kong/plugins/aws-lambda/v4.lua in /home/travis/install-cache/f99b7d5b0a5f6c9d070ff6ce527637ac/luarocks/lib/luarocks/rocks-5.1/kong/1.3.0-0/lua/kong/plugins/aws-lambda/v4.lua: The source and destination are the same files

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these lines from the rockspec:

kong/kong-1.3.0-0.rockspec

Lines 348 to 350 in fe3088a

["kong.plugins.aws-lambda.handler"] = "kong/plugins/aws-lambda/handler.lua",
["kong.plugins.aws-lambda.schema"] = "kong/plugins/aws-lambda/schema.lua",
["kong.plugins.aws-lambda.v4"] = "kong/plugins/aws-lambda/v4.lua",
I'm able to successfully run make dev in my clean Ubuntu machine. I think it makes sense since we're removing it from the codebase.

@Tieske
Copy link
Member Author

Tieske commented Oct 5, 2019

@murillopaula good catch! updated

aws-lambda plugin now lives in its own repo. It also was upgraded
with several new features. See changelog.
@ghost
Copy link

ghost commented Oct 5, 2019

@Tieske rebase current 'next' branch to make travis happy

@Tieske
Copy link
Member Author

Tieske commented Oct 7, 2019

rebase current 'next' branch to make travis happy

had already done so, but needed a few job-restarts to finally pass

@ghost
Copy link

ghost commented Oct 7, 2019

@Tieske FYI the plugin's CI tests pass when pointing to your 'lambda' branch: Kong/kong-plugin-aws-lambda#7

@kikito
Copy link
Member

kikito commented Oct 7, 2019

Hi, I have approved this change on this repo. However, I believe that some work is needed on the new aws-lambda repo. In particular, these:

* feat: if no credentiuals are provided, the plugin will automatically fetch EC2 or ECS credentials and use the AWS IAM roles retrieved for accessing the Lambda.
* feat: new option awsgateway_compatible to make the serialized request compatible with the AWS gateway format, making the plugin a drop-in replacement
* feat: new option skip_large_bodies to enable really large bodies (that have been cached to disk) to also be sent to the Lambda. Use with care!
( feat: added the ability to connect to the Lambda through a proxy

Seem to be missing.

@Tieske
Copy link
Member Author

Tieske commented Oct 8, 2019

@kikito the changelog was updated (and merged), see Kong/kong-plugin-aws-lambda#9

@kikito kikito merged commit 6412a31 into next Oct 8, 2019
@kikito kikito deleted the lambda branch October 8, 2019 16:13
dndx pushed a commit that referenced this pull request Nov 1, 2019
aws-lambda plugin now lives in its own repo. It also was upgraded
with several new features. See changelog.
hutchic pushed a commit that referenced this pull request Nov 21, 2019
aws-lambda plugin now lives in its own repo. It also was upgraded
with several new features. See changelog.
snt8amr pushed a commit to snt8amr/kong that referenced this pull request May 30, 2020
aws-lambda plugin now lives in its own repo. It also was upgraded
with several new features. See changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants