fix(admin) proper support for PUT /{entities}/{entity}/plugins/{plugin}
#4288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch,
PUT
requests to plugins under their associatedresources (e.g.
/services/{service}/plugins/{plugin}
) wouldsystematically return
404
, instead of creating the plugin if it didnot exist. This was because the
before
Lapis hook attempts to retrievethe plugin in the database before modifying it. Those endpoints are
preserved for backwards-compatibility purposes (being too nested to be
auto-generated), so that workaround is fine.
This patch ensures that we skip this logic with
PUT
requests, plusmakes sure that we set the
self.args.post
arguments according to theself.params
arguments (path segments with foreign UUIDs).Thanks @gszr for the report.