feat(core) make service on routes optional (transparent proxying) #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
added
the
pr/discussion
bungle
force-pushed
the
feat/serviceless-routes
branch
2 times, most recently
from
bbbc13e to
7f044bd
Compare
|
@james-callahan can you do a small feasability check on this? Am I on a right page, or do you see some problems? If everything is fine, I think I can move to adding tests. |
kikito
previously requested changes
Feb 8, 2019
bungle
force-pushed
the
feat/serviceless-routes
branch
2 times, most recently
from
3d2d9f6 to
f1f80f8
Compare
james-callahan
approved these changes
Feb 11, 2019
bungle
force-pushed
the
feat/serviceless-routes
branch
from
f1f80f8 to
236bae7
Compare
bungle
force-pushed
the
feat/serviceless-routes
branch
2 times, most recently
from
d14dd46 to
7bb0a18
Compare
james-callahan
suggested changes
Feb 13, 2019
bungle
force-pushed
the
feat/serviceless-routes
branch
8 times, most recently
from
e854fc7 to
9aa28fb
Compare
james-callahan
suggested changes
Feb 18, 2019
bungle
force-pushed
the
feat/serviceless-routes
branch
7 times, most recently
from
0b9dfc9 to
72ba79e
Compare
james-callahan
approved these changes
Mar 11, 2019
bungle
force-pushed
the
feat/serviceless-routes
branch
7 times, most recently
from
f833f45 to
7dc18a5
Compare
thibaultcha
previously requested changes
Mar 11, 2019
bungle
force-pushed
the
feat/serviceless-routes
branch
from
7dc18a5 to
61d2f14
Compare
bungle
force-pushed
the
feat/serviceless-routes
branch
from
61d2f14 to
af0775f
Compare
hutchic
reviewed
Mar 11, 2019
| service_scheme = uri_scheme | ||
| service_host = lower(matches[2]) | ||
| end | ||
| --[[ TODO: check if these make sense here? |
There was a problem hiding this comment.
I wanted to leave them here, maybe we return back to that later. I believe we need Connect for that to work, but I am not 100% sure.
bungle
force-pushed
the
feat/serviceless-routes
branch
5 times, most recently
from
c3fb21b to
11e7453
Compare
Make route.service optional, and when not set, route transparently on such route.
bungle
force-pushed
the
feat/serviceless-routes
branch
from
11e7453 to
6df1e40
Compare
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is first implementation of so called
allow_by_defaultrouting. E.g. routes that act as a transparent routes. Which means you don't need to create service entity, but instead you can use HTTP proxying oriptablestransparent proxying rules.