Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(basic-auth, ldap-auth, key-auth, jwt, hmac-auth) status code for unauthorized requests #4238

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

alaminopu
Copy link
Contributor

Summary

Fix(basic-auth, ldap-auth, key-auth, jwt, hmac-auth) status code for unauthorized requests

Full changelog

  • Fix status code from 403 to 401 for unauthorized requests for basic-auth plugin #3713
  • Fix status code from 403 to 401 for unauthorized requests for key-auth plugin
  • Fix status code from 403 to 401 for unauthorized requests for ldap-auth plugin
  • Fix status code from 403 to 401 for unauthorized requests for jwt plugin
  • Fix status code from 403 to 401 for unauthorized requests for hmac-auth plugin

Issues resolved

Fix #3713

…us code for unauthorized requests

The appropriate status code when the request is not authenticated
on an endpoint should be 401. Previously it was 403

Fix Kong#3713
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2019

CLA assistant check
All committers have signed the CLA.

@hishamhm hishamhm added this to the 1.1.0 milestone Feb 14, 2019
@hishamhm hishamhm merged commit 5000dcd into Kong:next Feb 14, 2019
@hishamhm
Copy link
Contributor

@alaminopu Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants