Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugins) make plugins defensive against possible errors between different phases #3976

Closed
wants to merge 4 commits into from
Closed

refactor(plugins) make plugins defensive against possible errors between different phases #3976

wants to merge 4 commits into from

Conversation

bungle
Copy link
Member

@bungle bungle commented Nov 13, 2018 •
edited by hishamhm
Loading

Summary

This PR consists of several fixes and commits:

The plugin changes

  1. chore(rate-limiting) make plugin defensive against possible errors and nil header values
  2. chore(response-transformer) make plugin defensive against possible errors and nil header values
  3. chore(response-ratelimiting) make plugin defensive against possible errors and nil header values
  4. chore(request-transformer) make plugin defensive against possible errors and nil header values

Relates to: #3924

@bungle bungle force-pushed the refactor/plugins-defensive branch from 250d5f7 to 0127bd6 Compare November 14, 2018 16:29
@bungle bungle force-pushed the refactor/plugins-defensive branch from 0127bd6 to 4285f18 Compare November 14, 2018 16:38
@hishamhm
Copy link
Contributor

@bungle changes LGTM! how complicated would it be to cause those error situations in a test so that we could we could regression-test this to ensure the plugins will remain defensive in the future?

@bungle bungle force-pushed the refactor/plugins-defensive branch from 4285f18 to 0ea8386 Compare November 20, 2018 09:03
@bungle bungle mentioned this pull request Nov 20, 2018
Closed
@bungle bungle force-pushed the refactor/plugins-defensive branch 10 times, most recently from 7b3c41d to b9d4f6c Compare November 21, 2018 21:48
@bungle bungle force-pushed the refactor/plugins-defensive branch from b9d4f6c to 8385b1a Compare November 21, 2018 22:23
@thibaultcha thibaultcha added this to the 1.0.0rc4 milestone Nov 30, 2018
@hishamhm hishamhm mentioned this pull request Nov 30, 2018
Merged
@kikito kikito force-pushed the refactor/plugins-defensive branch from 61bdace to 8385b1a Compare December 4, 2018 11:19
@hishamhm
Copy link
Contributor

hishamhm commented Dec 4, 2018

Closing this one as the fixes for the plugin issues this fixes were split into #4006 (in rc3), #4038 and #4039

@hishamhm hishamhm closed this Dec 4, 2018
@bungle bungle deleted the refactor/plugins-defensive branch December 10, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0rc4
Development

Successfully merging this pull request may close these issues.
3 participants
@bungle @hishamhm @thibaultcha