feat(migrations) implement post up and teardown functionality in connectors #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
reviewed
Nov 8, 2018
| self.connector:close() | ||
| return nil, prefix_err(self, err) | ||
| end | ||
| end |
There was a problem hiding this comment.
When both run_up and run_teardown are given, this will wait for schema consensus twice (and print the verbose logs twice as well). Will update locally.
thibaultcha
reviewed
Nov 8, 2018
| end | ||
|
|
||
|
|
||
| function _mt:post_run_teardown_migrations() |
There was a problem hiding this comment.
We should probably not bother with those since the parent class defines these... Will update as well.
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements a way to run a strategy specific code after
upandteardownmigration phases. For Cassandra it also implementsa wait for consensuson those calls.It is made according to this comment on issue #3924:
#3924 (comment)