feat(pdk) add consumer, service, route handling #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
reviewed
Oct 26, 2018
Tieske
force-pushed
the
one-more-pdk
branch
2 times, most recently
from
0025398 to
1d5e213
Compare
kikito
reviewed
Oct 31, 2018
Adds getters/setters to the PDK for the consumer (+credential), service, and route entities.
kikito
reviewed
Nov 1, 2018
kong/pdk/client.lua
Outdated
|
|
||
|
|
||
| --- | ||
| -- Sets the authenticated consumer (and credential) for the current request. |
There was a problem hiding this comment.
I think the description should be Sets the authenticated consumer and/or credential. The current wording makes it sound like consumer is mandatory and credential is optional.
There was a problem hiding this comment.
I think the description also needs to have a note "While both consumer and credential can be nil, it is required that at least one if them exists. Otherwise this function will throw an error".
kikito
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consumer(+credential),service, androuteentities.Replaces #3909