Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pdk) add kong.request.get_path_and_querystring #3859

Closed
wants to merge 2 commits into from

Conversation

kikito
Copy link
Member

@kikito kikito commented Oct 16, 2018

When the path + querystring is needed, this prevents having to manually check wether the querystring is present and concatenating the path + "?" + the query string every time.

Needed for the zipkin plugin. Kong/kong-plugin-zipkin#24

When the path + querystring is needed, this prevents having to manually check wether the querystring is present and concatenating the path + "?" + the query string every time.

Needed for the zipkin plugin.
@bungle bungle changed the title feat(pdk) add kong.response.get_path_and_querystring feat(pdk) add kong.request.get_path_and_querystring Oct 16, 2018
@bungle
Copy link
Member

bungle commented Oct 16, 2018

Needed here too:
#3845 (review)

Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks ok, but I'd wish the naming was a bit more consistent, what do you think @kikito?

@kikito
Copy link
Member Author

kikito commented Oct 17, 2018

closing in favor of #3842 (will do @bungle's suggested rename there)

@kikito kikito closed this Oct 17, 2018
@kikito kikito deleted the feat/groundwork-for-zipkin branch October 17, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants