feat(*) port plugins entities and Admin endpoints to the new DAO #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
feat/new-db-plugins-daos
branch
from
a59dc35 to
1a0924e
Compare
hishamhm
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
LGTM — any questions I had earlier this week were already answered by @kikito, and I see the 02-api_spec was also deleted, so this looks good to go! Thanks @thibaultcha for rebasing and PRing this
|
Merged with merge commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work from @kikito to port plugins entities over to the new DAO, to the exception of the OAuth2 plugin.