feat(db) make schema set fields to default if missing from DB #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamhm
force-pushed
the
feat/auto-defaults
branch
2 times, most recently
from
6225d6e to
e4cb490
Compare
Make records in Entities non-nullable by default, so that they return their full structure on API queries. The idea of returning explicit nulls in API queries was to allow users to see what are the available fields. In nested structures, for that to happen we need to make records non-nullable, even if their individual fields are. A field of the `record` type in an Entity can still be made nullable if desired, with an explicit `nullable = true` property. This is done at the Entity level because the MetaSchema uses nullable records extensively.
hishamhm
force-pushed
the
feat/auto-defaults
branch
3 times, most recently
from
0f16905 to
eb2af97
Compare
This allows us to auto-fill the then_field with a default and not require the presence of the if_field when performing a partial update.
hishamhm
force-pushed
the
feat/auto-defaults
branch
from
eb2af97 to
57235ea
Compare
thibaultcha
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes new semantics for handling missing or unset values arriving from the strategies. With this PR, the DAO will apply the default values if a strategy returns a column as
ngx.nulland is marked asnullable = falsein a schema. We also make records in entities non-nullable by default, so that we always recurse their structure, filling defaults for their fields.This will allow us to produce default values in newly-added columns without requiring a migration filling the table with default values.