Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rockspec) bump lua-resty-healthcheck to 0.4.2 #3496

Closed
wants to merge 1 commit into from

Conversation

hishamhm
Copy link
Contributor

No description provided.

@thibaultcha
Copy link
Member

@hishamhm Could we send this to master maybe?

@hishamhm
Copy link
Contributor Author

But we don't bump dependencies on point releases, right?

@hishamhm
Copy link
Contributor Author

Or is it fine to bump in a point-release, given that it is itself a point-release? (That would make sense.)

@thibaultcha
Copy link
Member

We do, but it depends on the content of the dependency bump. In this case, we have a fix and a refactor, so it is a bit hard to send it to master indeed...

thibaultcha pushed a commit that referenced this pull request May 30, 2018
* Send `Host` header in probe requests during active health checking.
* Refactor health check counters management.

See: https://github.com/Kong/lua-resty-healthcheck#042-23-may-2018

From #3496

Signed-off-by: Thibault Charbonnier <[email protected]>
@thibaultcha
Copy link
Member

Pushed to master!

@thibaultcha thibaultcha deleted the chore/bump-lua-resty-healthcheck branch May 30, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants