Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin) do not corrupt the plugin table when reading the schema #3348

Merged
merged 1 commit into from
Mar 28, 2018
Merged

fix(admin) do not corrupt the plugin table when reading the schema #3348

merged 1 commit into from
Mar 28, 2018

Conversation

hishamhm
Copy link
Contributor

Make remove_functions produce a copy instead of modifying the plugin
schema table in-place.

FIxes #3222.

@hishamhm
fix(admin) do not corrupt the plugin table when reading the schema
0822081 
Make `remove_functions` produce a copy instead of modifying the plugin
schema table in-place.

FIxes #3222.
@thibaultcha thibaultcha merged commit 1575824 into master Mar 28, 2018
@thibaultcha thibaultcha deleted the fix/plugin-schema branch March 28, 2018 00:48
@thibaultcha thibaultcha mentioned this pull request Mar 28, 2018
Closed
@thibaultcha
Copy link
Member

Thanks!

kikito pushed a commit to kikito/kong that referenced this pull request Apr 10, 2018
@hishamhm @kikito
fix(admin) do not mutate plugins schema in /plugins/schema/:name
94c614a 
Make `remove_functions` produce a copy instead of modifying the plugin
schema table in-place.

Fix Kong#3222
From Kong#3348
@bungle bungle mentioned this pull request May 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcha thibaultcha thibaultcha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishamhm @thibaultcha