fix(cli) catch compilation errors of nginx config templates #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, an error in the Penlight template for custom nginx configurations would result in `compile_conf()` returning `nil`, which would result in errors later in the execution path (trying to write a `nil` value at `<prefix>/nginx-kong.conf` instead of a `string`). This fix now catches errors returned by `pl_template.substitute`.
thibaultcha
force-pushed
the
fix/catch-template-errors
branch
from
15c4550 to
f4b5952
Compare
|
approved pending a flaky test (restarted it in CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, an error in the Penlight template for custom nginx
configurations would result in
compile_conf()returningnil, whichwould result in errors later in the execution path (trying to write a
nilvalue at<prefix>/nginx-kong.confinstead of astring).This fix now catches errors returned by
pl_template.substitute.