Trying to change keyspace before creating it (in case it was already … #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
pushed a commit
that referenced
this pull request
Feb 7, 2018
When the keyspace was already created by a DBA, we would still attempt to create it, possibly failing (due to insufficient permissions) and the migrations would error out. Instead, the new behavior ensures that if the keyspace already exists, we simply switch to it and do not attempt any creation. The previous behavior (creating the keyspace if it does not exist) is still effective. Fix #2987 From #3203 Signed-off-by: Thibault Charbonnier <[email protected]>
|
Very nice, manually merged to master with a few modifications. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #2987 : it often happens that for production systems, DB administrators are the only ones able to create Keyspaces in Cassandra, while DB accounts used at service runtime are not granted this right. In this situation, the Kong migration process will never be allowed to create the keyspace.
This PR allows both legacy behavior (migration process is creating keyspace) but also a new behavior (keyspace has been pre-created by a DBA, out of Kong migration process, so migration process does not consider the keyspace creation failure as a fatal error)
Full changelog
Issues resolved
Fix #2987