Admin API: Return 404 on call to GET /certificates/uuid #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerating a 500 status code
thibaultcha
pushed a commit
that referenced
this pull request
Jan 20, 2018
We now properly return HTTP 404 Not Found when the certificate's id specified in the URL is non-existing. From #3148 Signed-off-by: Thibault Charbonnier <[email protected]>
|
Nice catch, thank you! Manually merged into master with a few minor modifications regarding the tests organization (tests can be nested under a single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying the Admin API for a specific certificate using a UUID that doesn't exist the result returned is a 500 status code.
This patch returns a 404 instead.