Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli) remove deprecated compile CLI tool #3069

Merged
merged 1 commit into from
Dec 13, 2017
Merged

chore(cli) remove deprecated compile CLI tool #3069

merged 1 commit into from
Dec 13, 2017

Conversation

p0pr0ck5
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 commented Dec 2, 2017

No description provided.

@p0pr0ck5 p0pr0ck5 force-pushed the chore/remove-cli-compile branch from f7bf8ce to aebe0c1 Compare December 2, 2017 01:30
@p0pr0ck5 p0pr0ck5 changed the title chore(*) remove deprecated compile CLI tool chore(cli) remove deprecated compile CLI tool Dec 2, 2017
thibaultcha
thibaultcha reviewed Dec 2, 2017
View reviewed changes
kong/cmd/compile.lua
return {
lapp = lapp,
execute = execute
}
Copy link
Member

@thibaultcha thibaultcha Dec 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to remove the integration tests for this command as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, these were obscured by the test name. Thanks 👍

@p0pr0ck5 p0pr0ck5 force-pushed the chore/remove-cli-compile branch from aebe0c1 to 0200aeb Compare December 2, 2017 01:38
thibaultcha
thibaultcha reviewed Dec 2, 2017
View reviewed changes
spec/01-unit/003-prefix_handler_spec.lua Outdated
@@ -54,282 +54,6 @@ describe("NGINX conf compiler", function()
end)
end)

describe("compile_kong_conf()", function()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those tests are still very much needed? We are only removing the integration tests around kong compile, but not changing the internals of how we build the Kong prefix directory (still the same way with kong prepare).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... No idea why I nuked this. whups :p

@thibaultcha thibaultcha added the pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. label Dec 3, 2017
@thibaultcha
Copy link
Member

@p0pr0ck5 Will you take care of updating this before our upcoming 0.12 release?

@thibaultcha thibaultcha added this to the 0.12.0 milestone Dec 8, 2017
@p0pr0ck5
Copy link
Contributor Author

p0pr0ck5 commented Dec 8, 2017

Yep, on my radar 👍

@p0pr0ck5 p0pr0ck5 force-pushed the chore/remove-cli-compile branch 2 times, most recently from 9a1950d to a1d3a52 Compare December 12, 2017 23:39
@p0pr0ck5
Copy link
Contributor Author

@thibaultcha have a gander now? Think I got the appropriate stuff now.

@p0pr0ck5 p0pr0ck5 added pr/status/please review and removed pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. labels Dec 13, 2017
@thibaultcha
Copy link
Member

@p0pr0ck5 Mind updating the reference to this feature in the kong.conf.default file as well?

https://github.com/Kong/kong/blob/master/kong.conf.default#L7

@thibaultcha thibaultcha added pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. and removed pr/status/please review labels Dec 13, 2017
@p0pr0ck5 p0pr0ck5 force-pushed the chore/remove-cli-compile branch from a1d3a52 to 43ef947 Compare December 13, 2017 05:18
@p0pr0ck5
Copy link
Contributor Author

@thibaultcha nice 👀, done!

@thibaultcha thibaultcha merged commit f83f9cb into next Dec 13, 2017
@thibaultcha
Copy link
Member

Awesome, thanks!

@thibaultcha thibaultcha deleted the chore/remove-cli-compile branch December 13, 2017 06:02
thibaultcha pushed a commit that referenced this pull request Jan 16, 2018
@p0pr0ck5 @thibaultcha
chore(cli) remove deprecated compile command
a6e96fd 
From #3069
thibaultcha pushed a commit that referenced this pull request Jan 19, 2018
@p0pr0ck5 @thibaultcha
chore(cli) remove deprecated compile command
31dd3d1 
From #3069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcha thibaultcha thibaultcha approved these changes

Assignees
No one assigned
Labels
pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done.
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@p0pr0ck5 @thibaultcha