fix(dao) allow self-signed certificates for migrations #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
fix/db-ssl-verify
branch
from
6c8dad3 to
26041cf
Compare
This fixes a reported issue that Kong would not be able to run migrations on PostgreSQL with self-signed certificates. The error "self signed certificate" that Kong raised indicated that the root CA was not made available to the cosocket in use. Because the CLI is interpreted by resty-cli, it is too late to set the resty-cli `lua_ssl_trusted_certificate` directive. The approach we historically take is to rely on LuaSocket/LuaSec in Kong's CLI and circumvant this limitation (the root CA file can be specified at runtime as part of the LuaSocket instantiation options). Fix #2856
Follow-up of 5e2d31e9f5d79c901ef5364eb8786c86c0ae5010 for the Cassandra DAO strategy.
thibaultcha
force-pushed
the
fix/db-ssl-verify
branch
from
26041cf to
68d358b
Compare
kikito
approved these changes
Sep 26, 2017
thibaultcha
added
pr/ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a reported issue that Kong would not be able to run
migrations on PostgreSQL with self-signed certificates. The error "self
signed certificate" that Kong raised indicated that the root CA was not
made available to the cosocket in use.
Because the CLI is interpreted by resty-cli, it is too late to set the
resty-cli
lua_ssl_trusted_certificatedirective.The approach we historically take is to rely on LuaSocket/LuaSec in
Kong's CLI and circumvant this limitation (the root CA file can be
specified at runtime as part of the LuaSocket instantiation options).
Fix #2856