feat(balancer) implement consistent hashing #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The check function could verify that hash_header{1,2} are only non-empty when their corresponding enum is set to "hash". As for the schema interface, instead of hash_header1 and hash_header2 I'd use names matching the enum fields they are arguments of: hash_on_header and hash_fallback_header (or else it might seem that both headers are matched), but that's a matter of taste. |
Tieske
added
pr/status/please review
and removed
pr/status/do not merge (to discuss)
labels
hishamhm
force-pushed
the
feat/hashing2
branch
from
cbf709e to
2160d44
Compare
Minor changes to adhere to the coding rules.
hishamhm
force-pushed
the
feat/hashing2
branch
from
2160d44 to
c5a5a99
Compare
hishamhm
approved these changes
Oct 30, 2017
Tieske
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
Oct 31, 2017
Tieske
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
Oct 31, 2017
Tieske
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 2, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 12, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 16, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 16, 2018
thibaultcha
pushed a commit
that referenced
this pull request
Jan 16, 2018
One can define 2 keys to hash on, if the first key returns nil, the fallback is used (for example if a header is not present). The options for the keys are: 1. `none`: do not use a hash, just do (weighted) round-robin. This is the default. 2. `consumer`: use the consumer_id, or if not found the credential_id. (later is for external auth like oauth2 or ldap) 3. `ip`: use the originating ip address 4. `header`: use the header specified in the additional header option. If there are multiple headers by this name, then all entries are used (concatenated) The hash value is created from the resulting string-value, and is calculated as a numerical crc32. PR #2875
thibaultcha
pushed a commit
that referenced
this pull request
Jan 19, 2018
One can define 2 keys to hash on, if the first key returns nil, the fallback is used (for example if a header is not present). The options for the keys are: 1. `none`: do not use a hash, just do (weighted) round-robin. This is the default. 2. `consumer`: use the consumer_id, or if not found the credential_id. (later is for external auth like oauth2 or ldap) 3. `ip`: use the originating ip address 4. `header`: use the header specified in the additional header option. If there are multiple headers by this name, then all entries are used (concatenated) The hash value is created from the resulting string-value, and is calculated as a numerical crc32. PR #2875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can define 2 keys to hash on, if the first key returns
nil, the fallback is used (for example if a header is not present). The options for the keys are:none: do not use a hash, just do (weighted) round-robin. This is the default.consumer: use theconsumer_id, or if not found thecredential_id. (later is for external auth likeoauth2orldap)ip: use the originating ip addressheader: use the header specified in the additional header option. If there are multiple headers by this name, then all entries are used (concatenated)The hash value is created from the resulting string-value, and is calculated as a numerical
crc32.