feat(key-auth) skip authenticating preflight OPTIONS requests #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preflight OPTIONS requests explicitly exclude user credentials and custom headers. The key-auth plugin should not attempt to authenticate OPTIONS requests, since browsers will strip Kong's apiKey header. Fix #1292
new config variable authenticate_preflight to control whether or not to authenticate OPTIONS requests.
Tieske
force-pushed
the
fix/key-auth-cors-options-requests
branch
2 times, most recently
from
2b3a041 to
a454a98
Compare
kikito
reviewed
Jul 27, 2017
kong/plugins/key-auth/handler.lua
Outdated
| @@ -149,6 +150,15 @@ end | |||
| function KeyAuthHandler:access(conf) | |||
| KeyAuthHandler.super.access(self) | |||
|
|
|||
| -- check if preflight request and wether it should be authenticated | |||
| if conf.authenticate_preflight == false and get_method() == "OPTIONS" then | |||
There was a problem hiding this comment.
Instead of making a "default true" option (authenticate_preflight) we could make a "default false" one (skip_preflight). That way the default nil would just work: if conf.skip_preflight and .... No migration needed.
There was a problem hiding this comment.
there are others already: https://github.com/Mashape/kong/blob/master/kong/plugins/cors/schema.lua#L24
if this gets merged into master I plan to create a PR against next that removes the comments, reverts this to if not conf.authenticate_preflight and ..., and implements the migration.
Tieske
added a commit
that referenced
this pull request
Jul 31, 2017
This belongs to PR #2743 which went into a minor version.
Tieske
added a commit
that referenced
this pull request
Aug 1, 2017
This belongs to PR #2743 which went into a minor version.
Tieske
force-pushed
the
fix/key-auth-cors-options-requests
branch
from
a454a98 to
3c10393
Compare
…m/ecmendenhall/kong into fix/key-auth-cors-options-requests
Tieske
force-pushed
the
fix/key-auth-cors-options-requests
branch
from
3c10393 to
59b607a
Compare
Tieske
added a commit
that referenced
this pull request
Aug 2, 2017
This belongs to PR #2743 which went into a minor version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased version of #1535
fixes #1292, #1535