feat(core) support static client SSL certificates #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0pr0ck5
force-pushed
the
feat/proxy_ssl_certificate
branch
from
e26a24a to
87e0b2a
Compare
Implement the proxy_ssl_certificate and proxy_ssl_certificate_key directives in the Kong template. Because OpenResty's balancer_by_lua handler does not cover client side certs, we cannot assign client certs on a configurable basis, and using complex values in cert values is unsupported in Nginx, we are left with a static approach that can only serve one cert/key pair.
p0pr0ck5
force-pushed
the
feat/proxy_ssl_certificate
branch
from
87e0b2a to
e972faa
Compare
thibaultcha
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 25, 2017
thibaultcha
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the proxy_ssl_certificate and proxy_ssl_certificate_key
directives in the Kong template. Because OpenResty's balancer_by_lua
handler does not cover client side certs, we cannot assign client
certs on a configurable basis, and using complex values in cert
values is unsupported in Nginx, we are left with a static approach
that can only serve one cert/key pair.
Full changelog
Issues resolved
Fix #1547