fix(oauth2) checking client app when refreshing a token #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
subnetmarco
commented
Apr 27, 2017
subnetmarco
commented
- When refreshing a token the client application ownership is properly checked
subnetmarco
force-pushed
the
fix/refresh-token
branch
from
957acf1 to
385f21d
Compare
p0pr0ck5
reviewed
Apr 27, 2017
| @@ -1501,6 +1512,27 @@ describe("#ci Plugin: oauth2 (access)", function() | |||
| local body = assert.res_status(200, res) | |||
| assert.is_table(ngx.re.match(body, [[^\{"refresh_token":"[\w]{32,32}","token_type":"bearer","state":"wot","access_token":"[\w]{32,32}","expires_in":5\}$]])) | |||
| end) | |||
| it("#only fails when the client used for the code is not the same clien used for the token", function() | |||
There was a problem hiding this comment.
do we want to leave the '#only' tag?
There was a problem hiding this comment.
also, typo, 'clien' => 'client'
kong/plugins/oauth2/access.lua
Outdated
| @@ -357,8 +357,13 @@ local function issue_token(conf) | |||
| if not token then | |||
| response_params = {[ERROR] = "invalid_request", error_description = "Invalid "..REFRESH_TOKEN} | |||
| else | |||
| response_params = generate_token(conf, ngx.ctx.api, client, token.authenticated_userid, token.scope, state) | |||
| singletons.dao.oauth2_tokens:delete({id=token.id}) -- Delete old token | |||
| -- Check that the token belongs the the client application | |||
There was a problem hiding this comment.
typo in comment: 'belongs to the client application'
subnetmarco
force-pushed
the
fix/refresh-token
branch
from
dc12509 to
b83a684
Compare
|
lgtm, apart from the Changelog conflict; since this is a merge to master and I'm not overly familiar with Oauth2, would like to get a second pair of eyes here. |
Tieske
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.