fix(cors) proper handling of the ACAC header #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access-Control-Allow-Credentials used to systematically be set to `false` if ACAC was `*`. However, `false` is an invalid value for ACAC, which only accepts `true`, and ACAO cannot be `*` when credentials are desired. * if credentials are desired, ACAO will be set to the request's Origin * ACAC never received `false` anymore * tests from @thefosk in #2243, plus one more to ensure port is included in ACAO if present in the request's Origin. Replace #2243
This was referenced Apr 25, 2017
p0pr0ck5
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access-Control-Allow-Credentials used to systematically be set to
falseif ACAC was*.However,
falseis an invalid value for ACAC, which only acceptstrue, and ACAO cannot be*when credentials are desired.falseanymoreincluded in ACAO if present in the request's Origin.
Replace #2243