fix(router) ensure preserve_host when no hosts
#2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The router avoids grabbing the headers if not absolutely necessary (at least one API configured with a `hosts` rule. This caused an edge-case and mislead the router into believing the headers were already grabbed, and returned a `nil` value instead of the request's Host header. * add a unit test case * add an integration test case, although more generic * use the `ngx.var.http_*` API to grab the request's Host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The router avoids grabbing the headers if not absolutely necessary (at
least one API configured with a
hostsrule. This caused an edge-caseand mislead the router into believing the headers were already grabbed,
and returned a
nilvalue instead of the request's Host header.Full changelog
ngx.var.http_*API to grab the request's Host