[feature] support unprepared statement errors. fix #11 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
changed the title
thibaultcha
force-pushed
the
fix/reprepare-statements
branch
from
df0f50d to
dc8c9a4
Compare
If Cassandra returns an unprepared error, the DAO will re-prepare it and try the query again. This fixes #11, and handles the case where Cassandra would go down, and then up again while Kong is still running. Other changes: - docs: base_dao and the factory have been given a better documentation. - refactor: - `kong_query` is now the prefered term for _queries elements. - `params` becomes `args_keys` and `values` `args` for consistance with the driver. - The `_execute` method was renamed to `_execute_kong_query` and broken into smaller chunks. - Batch statements now need to use the raw `_execute` method (the new one, not the one renamed to `_execute_kong_query`. - Cassandra errors now also have the error code.
thibaultcha
force-pushed
the
fix/reprepare-statements
branch
from
dc8c9a4 to
cdf94a0
Compare
|
Changes Unknown when pulling cdf94a0 on fix/reprepare-statements into * on master*. |
thibaultcha
added a commit
that referenced
this pull request
Apr 30, 2015
[feature] support unprepared statement errors. fix #11
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature] support unprepared statement errors. fix Kong#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Cassandra returns an unprepared error, the DAO will re-prepare it and try the query again. This fixes #11, and handles the case where Cassandra would go down, and then up again while Kong is still running.
Other changes:
kong_queryis now the prefered term for _queries elements.paramsbecomesargs_keysandvaluesargsfor consistance with the driver._executemethod was renamed to_execute_kong_queryand broken into smaller chunks._executemethod (the new one, not the one renamed to_execute_kong_query.