feat(plugins) anonymous authentication in auth plugins #1666
Conversation
|
wouldn't this automatically add multi-auth support (in a logical OR fashion?) |
|
@Tieske yes, if all of them have |
| @@ -101,7 +105,7 @@ function _M.execute(conf) | |||
| end | |||
|
|
|||
| if not credential or not validate_credentials(credential, given_password) then | |||
| return responses.send_HTTP_FORBIDDEN("Invalid authentication credentials") | |||
| return false, {status = 403, message = "Invalid authentication credentials"} | |||
There was a problem hiding this comment.
why not just return success, statuscode, message without creating the intermediate table? More efficient and less GC.
same for the other plugins
| ngx_set_header(constants.HEADERS.CONSUMER_ID, consumer.id) | ||
| ngx_set_header(constants.HEADERS.CONSUMER_CUSTOM_ID, consumer.custom_id) | ||
| ngx_set_header(constants.HEADERS.CONSUMER_USERNAME, consumer.username) | ||
| ngx_set_header(constants.HEADERS.CREDENTIAL_USERNAME, credential.username) |
There was a problem hiding this comment.
can't we cache those constants locally? the above are 15 table lookups
same for the other plugins
| @@ -26,7 +26,8 @@ return { | |||
| RATELIMIT_REMAINING = "X-RateLimit-Remaining", | |||
| CONSUMER_GROUPS = "X-Consumer-Groups", | |||
| FORWARDED_HOST = "X-Forwarded-Host", | |||
| FORWARDED_PREFIX = "X-Forwarded-Prefix" | |||
| FORWARDED_PREFIX = "X-Forwarded-Prefix", | |||
| ANONYMOUS = "X-Anonymous-Consumer" | |||
There was a problem hiding this comment.
please use trailing comma for table constructors, to keep the diff clean
same for the other plugins
|
+1 |
|
Thanks Tieske. So it looks like if I want to force one authentication or the other it is not possible. Excluding the anonymous access. So as I see it we should be defining 2 paths to accomplish this. right? |
Summary
Adds support for anonymous authentication in every authentication plugin. When
config.anonymous=true, even non-authenticated requests are allowed and the plugins will append aX-Anonymous-Consumer: trueheader to the upstream request.Full changelog
anonymousconsumersanonymousconsumersanonymousconsumersanonymousconsumersanonymousconsumersanonymousconsumersIssues resolved
Fix #853.