fix(conf) fallback for lack of value for var placeholders #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
changed the title
thibaultcha
force-pushed
the
fix/template-defaults
branch
from
5b2b5ed to
bf0cbb4
Compare
thibaultcha
changed the title
`anonymous_reports=on` + `socket.toip` not resolving (ex: no internet connection) would make Kong use an invalid Nginx template (with variable placeholders untouched).
|
lgtm |
Tieske
added
pr/ready (but hold merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case when
anonymous_reports=on+socket.toipis notresolving (ex: no internet connection) Nginx would be started with an
invalid configuration file because Kong's nginx config template would have an untouched
${{SYSLOG_REPORTS}}placeholder left. Seeprefix_handker.lua'scompile_conf()function.This ensures that by default, some of those variables (holding the directive name + value) are at least removed from the template before starting.