Fixing the response value of /plugins/enabled

[subnetmarco]

The response of /plugins/enabled now returns a proper JSON array. This was a bug introduced with v0.9.

Full changelog

• /plugins/enabled returns a JSON array like it did in < 0.9 and not a JSON object.

[thibaultcha]

If this was introduced, it's because there was no test for this behavior. A test should be added.

[subnetmarco]

Test added.

[thibaultcha]

Actually that should not have been merged, plenty of things are still wrong and missing.

[subnetmarco]

@thibaultcha This PR fixes the output of /plugins/enabled. As such, it includes a patch for the handler of that endpoint to return the expected result + a test that verifies that the returned value is a Lua array and not a table.

To reduce the back and forth on issues it would be beneficial to list all the issues in the first comment so we can address all of them immediately.

[thibaultcha]

Other comments were specific to the code and I was writing them. Thy can't all be posted at once.
That's why we have review/ready labels.

On Aug 22, 2016, at 4:15 PM, Marco Palladino [email protected] wrote:

@thibaultcha This PR fixes the output of /plugins/enabled. As such, it includes a patch for the handler of that endpoint to return the expected result + a test that verifies that the returned value is a Lua array and not a table.

To reduce the back and forth on issues it would be beneficial to list all the issues in the first comment so we can address all of them immediately.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.