-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix analytics with new format #12889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, can you change the commit description according to the convention?
@gruceo can you please merge to Kong and Kong-ee if it looks ok? Thanks |
0ec725d
to
5697645
Compare
I can handle the Kong-EE cherry-picking and stuff, I have been set on to this to get everything done before next week. Just need this merging to allow proceeding the other remaining PRs. |
Set rebase when merging master back in; my fix conflicts now... |
Tests should pass now |
995d5b1
to
97ce4fb
Compare
Wait I have pulled in commits now in this PR |
97ce4fb
to
bc4967d
Compare
@gruceo ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, wait for @brentos to approve then we can merge.
@tysoekong @ttyS0e there are 14 commits in this PR, so we should squash. |
@brentos Do you approve also? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gruceo Will it let you push squash and merge? |
Successfully created cherry-pick PR for |
Summary
This PR is a fixed of #12583
We need to refactor as many observability providers do not simplify ingest array. Here is a new nested format:
Current model is:
New model if using several plugins:
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]
KAG-3759
KAG-4124
EDIT: format JSON snippets