fix(balancer): ensure the notify callback is invoked only if defined when handling cached connection errors #12480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when handling cached connection errors address comments of Kong#12346 Signed-off-by: tzssangglass <[email protected]>
tzssangglass
added
cherry-pick kong-ee
|
Review patches for tzssangglass:fix_max_retry_for_28 -> release/2.8.x on tzssangglass/kong: https://github.com/Kong/openresty-patches-review/pull/44/files |
chronolaw
approved these changes
Feb 1, 2024
chronolaw
removed
the
cherry-pick kong-ee
Signed-off-by: tzssangglass <[email protected]>
chobits
approved these changes
Feb 1, 2024
|
Pending engineering discussions, please hold off merging for now. |
|
We need to revert #12346 |
|
close by: #12497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
address comments of #12346
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference