Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(router/atc): remove tail calls to avoid NYIs #12476

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Feb 1, 2024

Summary

As #12467 did, remove some tail return NYI to be more JIT-friendly.

KAG-3634

Checklist

Issue reference

Fix #[issue number]

@chronolaw chronolaw changed the title perf(router/atc): remove tail return NYI in router perf(router/atc): remove tail return NYIs in router Feb 1, 2024
@chronolaw chronolaw force-pushed the perf/remove_tail_return_nyi branch from 8219c6a to 6f36ea5 Compare February 26, 2024 02:24
@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 26, 2024
@chronolaw chronolaw changed the title perf(router/atc): remove tail return NYIs in router refactor(router/atc): remove tail return NYIs in router Feb 27, 2024
kong/router/atc.lua Show resolved Hide resolved
kong/router/compat.lua Show resolved Hide resolved
kong/router/compat.lua Show resolved Hide resolved
kong/router/compat.lua Show resolved Hide resolved
kong/router/compat.lua Outdated Show resolved Hide resolved
kong/router/compat.lua Outdated Show resolved Hide resolved
kong/router/compat.lua Outdated Show resolved Hide resolved
kong/router/atc.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP changed the title refactor(router/atc): remove tail return NYIs in router refactor(router/atc): remove tail calls to avoid NYIs Feb 27, 2024
@ADD-SP ADD-SP merged commit 518d1ff into master Feb 27, 2024
28 checks passed
@ADD-SP ADD-SP deleted the perf/remove_tail_return_nyi branch February 27, 2024 05:52
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/router size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants