Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-gui): make admin_gui_ssl_cert_key sensitive #11332

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Jul 31, 2023

Summary

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

... to prevent it been printed to console unexpectedly
@nekolab nekolab force-pushed the fix/make-admin-gui-cert-key-sensitive branch from ba0efe0 to d92eabe Compare July 31, 2023 09:41
@nekolab nekolab marked this pull request as ready for review July 31, 2023 09:43
@fffonion fffonion merged commit 5741a18 into master Jul 31, 2023
@fffonion fffonion deleted the fix/make-admin-gui-cert-key-sensitive branch July 31, 2023 09:50
@team-gateway-bot
Copy link
Collaborator

The backport to release/3.4.x failed:

Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-11332-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5741a18a8d7e7243610682c8299c2f69bf3892c1
# Push it to GitHub
git push --set-upstream origin backport-11332-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x

Then, create a pull request where the base branch is release/3.4.x and the compare/head branch is backport-11332-to-release/3.4.x.

team-gateway-bot pushed a commit that referenced this pull request Jul 31, 2023
... to prevent it been printed to console unexpectedly

(cherry picked from commit 5741a18)
@kikito kikito mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants