-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): support aws xray propagation #11075
feat(tracing): support aws xray propagation #11075
Conversation
ccfcd29
to
771924c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good overall, thank you for the contribution! Please see my inline comments and add an entry to CHANGELOG.md
. If you could suggest what needs to be added to the documentation (source), it'd be much appreciated.
771924c
to
c412f14
Compare
Thanks for the review, here is the small PR for the documentation: Kong/docs.konghq.com#5732 |
1cf3507
to
be4bf0e
Compare
be4bf0e
to
a5d0f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall! I just left a couple of minor comments
a5d0f55
to
2ea5244
Compare
cherry-pick to EE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: sorry, wrong repo 🤦
This PR adds support for the AWS X-Ray trace propagation header.
Summary
Because Amazon X-Ray uses a custom trace id format, without proper support of the
X-Amzn-Trace-Id
header, it's not possible to store kong's traces in xray.Doc about
X-Amzn-Trace-Id
:https://docs.aws.amazon.com/xray/latest/devguide/xray-concepts.html#xray-concepts-tracingheader
Existing implementations in JS and Python:
Checklist
Full changelog