fix(request-transformer): thread safety #10539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ms2008 what do you think about this test? |
samugi
force-pushed
the
fix/request-transformer-thread-safety
branch
from
f7c2575 to
36ddefc
Compare
samugi
force-pushed
the
fix/request-transformer-thread-safety
branch
2 times, most recently
from
c31bfc7 to
67927af
Compare
Make the template environment thread safe by scoping it to the request rather than the module This was problematic because reading the body (during body transformation) results in yielding.
samugi
force-pushed
the
fix/request-transformer-thread-safety
branch
from
67927af to
aea629a
Compare
ms2008
approved these changes
Mar 23, 2023
kikito
approved these changes
Mar 23, 2023
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
* tests(rbac): fix 01-rbac/01-rbac_spec.lua (#10463) * db(dao/workspaces): check kong.conf in select_by_name * fix 01-rbac/01-rbac_spec.lua * tests(keyring): pagesize must not be less than 2 (#10462) * (keyring): pagesize must not be less than 2 * comments * math.max * fix(*): remove hardcoded size 1000 from :each interface call (#10480) * set ws_id nil in tests (#10488) * fix(incremental sync): fix bug that CP generates entity without expanding foreigns (#10526) * fix(incremental sync): fix bug that CP generates entity without expanding foreigns * added XXX EE only * chore: fallback workspace (#10469) * remove field_ws_id * Revert "remove field_ws_id" This reverts commit 880f5dac107364c7df9800b910631ce1c94451b2. --------- Co-authored-by: Xiaochen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a porting of EE/4816
Make the template environment thread safe by scoping it on the request rather than on the module level.
Checklist
Full changelog
Issue reference
KAG-933