-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins renaming #480
Comments
should perhaps prefix with something to indicate "official" status e.g. |
That makes it painful to configure though (especially since all of them are currently official). I would rather wait until we have our own plugins platform and a web UI certifying them as official. |
yep
I think the community is already itching for plugin separation, and some already are forking and adding their own functionality to plugins, some maybe existing plugins too (under the same name) if we're taking the opportunity to do a single renaming now, then might as well. also, we can also follow a "namespace" approach, much like docker:
|
official/not official: i see this coming but not soon. we'll need to have a "dockerhub/atmopshere" platform first. |
Renaming basicauth and keyauth will change the route:
to:
And to keep things consistant, I would also change the routes:
to:
Now that would be kind of a breaking change. So should we:
|
option 4:
|
I didn't want to consider this option since we are still in 0.x and don't already want to start with maintaining backwards compatibility all across the project. For ex the migration script finally takes care of migrating some data for us to remove the backwards compatibility support in the code. Same for plugins renaming, we really want to move forwards. Now I can do it but the spirit of 0.5.0 was to finally move forward in a lot of stuff we postponed. PS: 0.5.0 should also proceed to the renaming of the configuration properties and db values (target_url -> upstream_url) |
#512 supports both routes and a deprecation notice in CHANGELOG and UPDATE. |
your argument is valid, I'm just listing additional option :) |
For consistency and usability plugins will be renamed. Since 0.5.0 includes a breaking change in the database schema (#443), it will also include a migration script. This script is a good opportunity to also rename plugins (since it would not be backwards compatible).
Naming conventions:
Here are some suggestions, please comment in this thread and this issue will be updated with approved suggestions:
The text was updated successfully, but these errors were encountered: