Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request transformer does not allow modification of Host header #445

Closed
ahmadnassri opened this issue Aug 2, 2015 · 1 comment
Closed

request transformer does not allow modification of Host header #445

ahmadnassri opened this issue Aug 2, 2015 · 1 comment
Labels
idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports.

Comments

@ahmadnassri
Copy link
Contributor

the request-transformer plugin should allow to modify the Host header just before sending the request (having resolved the endpoint of target_url), however, currently attempting to overwrite the Host header does nothing.

this is related to #444, and can potentially be solved by one of the suggested solutions there, or alternatively introducing that option here as part of the request transformer function.
@ahmadnassri ahmadnassri mentioned this issue Aug 2, 2015
Closed
@ahmadnassri ahmadnassri added proxy idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports. and removed proxy labels Aug 3, 2015
@ahmadnassri
Copy link
Contributor Author

should we keep this as an item to investigate?

context: the original need here was for preserve_host yet this is still technically separate

xvaara added a commit to xvaara/kong that referenced this issue Oct 3, 2015
@xvaara
Merge remote-tracking branch 'Mashape/master'
99c0227 
* Mashape/master: (23 commits)
  Update README.md
  Update README.md
  Closing Kong#562
  Adding wait time before ratelimiting tests
  Fixing test
  fix(jwt) handle `iss` not being found in jwt credentials
  Update README.md
  docs(update) remove redundancy
  docs(update) fix layout
  fix(test) fix config test after Kong#563
  Update README.md
  Adding missing statement for Kong#571
  perf(analytics) global optimizations
  fix(plugins) make default config for plugins an empty object
  Closes Kong#445
  dbocs(changelog) 0.5.0 changes
  Better content-type check in response-transformer plugin
  Closes Kong#535
  Fixes the root problem at Kong#565
  fix(key-auth) remove support for key in request body
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahmadnassri