Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean output of kong stop when no process is running #235

Closed
ahmadnassri opened this issue May 13, 2015 · 3 comments
Closed

clean output of kong stop when no process is running #235

ahmadnassri opened this issue May 13, 2015 · 3 comments

Comments

@ahmadnassri
Copy link
Contributor

should probably remove the second and third (empty) lines:

[INFO] Using configuration: /etc/kong/kong.yml
sh: 1: kill: No such process

[INFO] Removing pid at: /usr/local/kong/kong.pid
[ERR] Not running. Could not find pid: 176
@subnetmarco
Copy link
Member

I think it's this line: https://github.com/Mashape/kong/blob/master/kong/cli/utils/signal.lua#L342

os.execute("kill -0 "..pid) == 0

@thibaultcha
Copy link
Member

This is what I see now:

kong|master ⇒ kong stop
[INFO] Using configuration: /etc/kong/kong.yml
[ERR] Not running. Could not find pid at: /usr/local/kong/kong.pid

has this been resolved?

@subnetmarco
Copy link
Member

It happens on an edge case scenario (not sure, but maybe when Kong is being killed but the PID file still has the old process id), and it also happens in the test: https://travis-ci.org/Mashape/kong/builds/69369029#L1028

subnetmarco added a commit that referenced this issue Aug 10, 2015
subnetmarco added a commit that referenced this issue Aug 10, 2015
ctranxuan pushed a commit to streamdataio/kong that referenced this issue Aug 25, 2015
Former-commit-id: 907eb6f66b5ffea68914cc1fcb0f8b74d982d297
ctranxuan pushed a commit to streamdataio/kong that referenced this issue Aug 25, 2015
Closes Kong#453 and Kong#235

Former-commit-id: 7c0f0001d8621a2a25ca91eeaa9f5771dd48a96e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants