-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(router): remove NYI to be more JIT-friendly #12467
Conversation
6353fdd
to
14fc1fe
Compare
14fc1fe
to
9e4947e
Compare
Not sure if CI is flaky, but seems like this may have caused issue. Restarting CI 3rd time. |
Seems to gone green now. |
Today is code freeze, so I am not sure do we want this in still? Seems like a stretch. How much this improves anything? |
d5e6b1f
to
edd163f
Compare
@ADD-SP are we going to merge this? Ping @chronolaw, can you review and approve? |
I already approved this PR and did some work on it, I think that we can merge it. |
192506e
to
66b56cd
Compare
Merge on CI green |
Successfully created cherry-pick PR for |
Please SQUASH AND MERGE
Summary
Generating a field accessor in place in the
get_field_accessor()
is not JIT friendly, so let' generate accessor from the other function.And tail call is not JIT-friendly in some cases, so rewrote it.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-3653