Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning if not using LuaJIT #121

Closed
thibaultcha opened this issue Apr 9, 2015 · 2 comments
Closed

Print a warning if not using LuaJIT #121

thibaultcha opened this issue Apr 9, 2015 · 2 comments

Comments

@thibaultcha
Copy link
Member

We should print a warning when an instance is spawned and not using LuaJIT. Basically running on bare Lua will be very slow. Throwing some benchmarks: http://luajit.org/performance_x86.html

if jit then
  -- LuaJIT
else
  -- Not LuaJIT (slower)
end

@SGrondin I hope your benchmarks are using LuaJIT :p

@subnetmarco
Copy link
Member

The warning can't be launched in the CLI because the CLI always uses the system Lua.
I have added a lua_version property at 127.0.0.1:8001/ that shows what version of Lua is being used by OpenResty.

The newer version of OpenResty are compiled by default always with LuaJIT. Because of this, I think we can close the issue.

@thibaultcha
Copy link
Member Author

I never said the warning should be printed from the CLI. (The CLI can also use LuaJIT btw, it's my setting).

hutchic pushed a commit that referenced this issue Jun 10, 2022
### Summary

#### libyaml 0.2.2 release

- #95 -- build: do not install config.h
- #97 -- appveyor.yml: fix Release build
- #103 -- Remove unused code in yaml_document_delete
- #104 -- Allow colons in plain scalars inside flow collections
- #109 -- Fix comparison in tests/run-emitter.c
- #117 -- Fix typo error
- #119 -- The closing single quote needs to be indented...
- #121 -- fix token name typos in comments
- #122 -- Revert removing of open_ended after top level plain scalar
- #125 -- Cherry-picks from PR 27
- #135 -- Windows/C89 compatibility
- #136 -- allow override of Windows static lib name

#### libyaml 0.2.3 release

- #130 Fixed typo.
- #144 Fix typo in comment
- #140 Use pointer to const for strings that aren't/shouldn't be modified
- #128 Squash a couple of warnings in example-deconstructor-alt
- #151 Fix spelling for error message
- #161 Make appveyor config be a hidden file
- #159 Add CHANGES file
- #160 Always output document end before directive (YAML 1.2 compatibility)
- #162 Output document end marker after open ended scalars
- #157 change cmake target name from libOFF.a to libyaml.a
- #155 include/yaml.h: fix comments
- #169 Fixed missing token in example
- #127 Avoid recursion in the document loader.
- #172 Support %YAML 1.2 directives
- #66 Change dllexport controlling macro to use _WIN32
catbro666 added a commit that referenced this issue Sep 7, 2023
bungle pushed a commit that referenced this issue Sep 7, 2023
* chore(deps): bump resty.openssl from 0.8.23 to 0.8.25

- **pkey:** clear error stack when verification fails ([#121](fffonion/lua-resty-openssl#121)) [6e58b28](fffonion/lua-resty-openssl@6e58b28)

- **ssl:** support ngx_lua 10025 [abaa66e](fffonion/lua-resty-openssl@abaa66e)

FIx [FTI-5324](https://konghq.atlassian.net/browse/FTI-5324)

* add changelog file

* Update CHANGELOG/unreleased/kong/11518.yaml

Co-authored-by: Chrono <[email protected]>

---------

Co-authored-by: Chrono <[email protected]>
bungle added a commit that referenced this issue Aug 19, 2024
### Summary

### [0.15.0] - 2024-08-14
#### bug fixes
- **tests:** use tlsv1.2 in dual cert test [415be3f](fffonion/lua-resty-acme@415be3f)
- **tests:** uses v3 protocol for etcd [c3928b5](fffonion/lua-resty-acme@c3928b5)

#### features
- **etcd:** etcd storage to use v3 protocol [a3353b3](fffonion/lua-resty-acme@a3353b3)
- **redis:** add support for username/password auth ([#121](fffonion/lua-resty-acme#121)) [186ab23](fffonion/lua-resty-acme@186ab23)

KAG-5189

Signed-off-by: Aapo Talvensaari <[email protected]>
bungle added a commit that referenced this issue Aug 19, 2024
### Summary

### [0.15.0] - 2024-08-14
#### bug fixes
- **tests:** use tlsv1.2 in dual cert test [415be3f](fffonion/lua-resty-acme@415be3f)
- **tests:** uses v3 protocol for etcd [c3928b5](fffonion/lua-resty-acme@c3928b5)

#### features
- **etcd:** etcd storage to use v3 protocol [a3353b3](fffonion/lua-resty-acme@a3353b3)
- **redis:** add support for username/password auth ([#121](fffonion/lua-resty-acme#121)) [186ab23](fffonion/lua-resty-acme@186ab23)

KAG-5189

Signed-off-by: Aapo Talvensaari <[email protected]>
curiositycasualty pushed a commit that referenced this issue Oct 15, 2024
- **tests:** use tlsv1.2 in dual cert test [415be3f](fffonion/lua-resty-acme@415be3f)
- **tests:** uses v3 protocol for etcd [c3928b5](fffonion/lua-resty-acme@c3928b5)

- **etcd:** etcd storage to use v3 protocol [a3353b3](fffonion/lua-resty-acme@a3353b3)
- **redis:** add support for username/password auth ([#121](fffonion/lua-resty-acme#121)) [186ab23](fffonion/lua-resty-acme@186ab23)

KAG-5189

Signed-off-by: Aapo Talvensaari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants