Allow w3c to be set as the default propagation for opentelemetry plugin #10246
Labels
Comments
|
FWIW, it does look like part of the issue reported was fixed with this: #10332 However, we still need the w3c headers to get set and passed along to the backend. |
|
@nbialostosky Are you up for a contribution? |
1 task
nbialostosky
added a commit
to nbialostosky/kong
that referenced
this issue
Apr 13, 2023
At the moment the opentelemtry plugin sets the `default_header_type` for propigations: https://github.com/Kong/kong/blob/master/kong/plugins/opentelemetry/handler.lua#L150 However, doesn't allow the modification of `header_type` in the `schema`, so it always defaults to `preserve`. However, based on the function it's calling: https://github.com/Kong/kong/blob/master/kong/tracing/propagation.lua#L432 > -- If conf_header_type is set to `preserve`, found_header_type is used over default_header_type; The above means the `default_header_type` is never used. We want the `default_header_type` to be used, and we want to ignore the incoming header type. This commit takes care of addressing this issue: Kong#10246 I am not implmenting the ability to modify the `default_header_type` as opentelemetry notes it should default to `w3c` which it currently is: https://opentelemetry.io/docs/concepts/signals/traces/#context-propagation
samugi
added a commit
that referenced
this issue
Apr 13, 2023
* feat(opentelemetry): Allow header_type to be set At the moment the opentelemtry plugin sets the `default_header_type` for propigations: https://github.com/Kong/kong/blob/master/kong/plugins/opentelemetry/handler.lua#L150 However, doesn't allow the modification of `header_type` in the `schema`, so it always defaults to `preserve`. However, based on the function it's calling: https://github.com/Kong/kong/blob/master/kong/tracing/propagation.lua#L432 > -- If conf_header_type is set to `preserve`, found_header_type is used over default_header_type; The above means the `default_header_type` is never used. We want the `default_header_type` to be used, and we want to ignore the incoming header type. This commit takes care of addressing this issue: #10246 I am not implmenting the ability to modify the `default_header_type` as opentelemetry notes it should default to `w3c` which it currently is: https://opentelemetry.io/docs/concepts/signals/traces/#context-propagation * Update kong/plugins/opentelemetry/schema.lua --------- Co-authored-by: Samuele Illuminati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Kong version (
$ kong version)3.1.1
Current Behavior
With the current implementation of opentelemetry propagation, we are having issues with non-w3c trace id's being 8 byte once they get to our backend.
The Zipkin plugin allows you to set a
default_header_type, though still has the similar issue with not converting 8byte to 16byte -- which we addressed with some changes locally.Expected Behavior
Implement similar behavior as the Zipkin plugin and allow a
default_header_typetype to be able to be set with opentelemetry.This even aligns with what OpenTelemtry states should be the default:
https://opentelemetry.io/docs/concepts/signals/traces/#context-propagation
Of note, even if this is allowed to be set, especially if set to w3c it will also need to ensure that 8byte trace id headers don't get to the backend. This could be accomplished a few ways:
Steps To Reproduce
Anything else?
No response
The text was updated successfully, but these errors were encountered: