fix(*) invert tcp-log and request-termination priority

Work done in #3079 highlighted that tcp-log executed with a lower priority than request-termination. While this functionally has not presented a significant problem, this commit cleans up the prioritization of these plugins to a more sane definition. This has the added benefit of not requiring the request-termination define its own delayed callback function once #3079 is merged. From #3089
Kong · Jan 16, 2018 · d41070b · d41070b
1 parent 72ce126
commit d41070b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/kong/plugins/request-termination/handler.lua b/kong/plugins/request-termination/handler.lua
@@ -6,7 +6,7 @@ local server_header = meta._NAME .. "/" .. meta._VERSION
 
 local RequestTerminationHandler = BasePlugin:extend()
 
-RequestTerminationHandler.PRIORITY = 7
+RequestTerminationHandler.PRIORITY = 2
 RequestTerminationHandler.VERSION = "0.1.0"
 
 function RequestTerminationHandler:new()

diff --git a/kong/plugins/tcp-log/handler.lua b/kong/plugins/tcp-log/handler.lua
@@ -4,7 +4,7 @@ local cjson = require "cjson"
 
 local TcpLogHandler = BasePlugin:extend()
 
-TcpLogHandler.PRIORITY = 2
+TcpLogHandler.PRIORITY = 7
 TcpLogHandler.VERSION = "0.1.0"
 
 local function log(premature, conf, message)

diff --git a/spec/01-unit/014-plugins_order_spec.lua b/spec/01-unit/014-plugins_order_spec.lua
@@ -66,12 +66,12 @@ describe("Plugins", function()
       "datadog",
       "file-log",
       "udp-log",
-      "request-termination",
+      "tcp-log",
       "loggly",
       "runscope",
       "syslog",
       "galileo",
-      "tcp-log",
+      "request-termination",
       "correlation-id",
     }