Skip to content

Commit

Permalink
fix(proxy): remove kong branding from kong HTML error template (#11150)
Browse files Browse the repository at this point in the history
* fix(proxy): remove kong branding in kong HTML error template

Signed-off-by: owl <[email protected]>

* fix(proxy): fix code

Signed-off-by: owl <[email protected]>

---------

Signed-off-by: owl <[email protected]>
  • Loading branch information
oowl authored Jun 29, 2023
1 parent 9281b4d commit cd9ad6c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
- Added a `User=` specification to the systemd unit definition so that
Kong can be controlled by systemd again.
[#11066](https://github.com/Kong/kong/pull/11066)
- Remove kong branding from kong HTML error template.
[#11150](https://github.com/Kong/kong/pull/11150)

#### Admin API

Expand Down
4 changes: 2 additions & 2 deletions kong/tools/utils.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1422,10 +1422,10 @@ do
<html>
<head>
<meta charset="utf-8">
<title>Kong Error</title>
<title>Error</title>
</head>
<body>
<h1>Kong Error</h1>
<h1>Error</h1>
<p>%s.</p>
</body>
</html>
Expand Down
4 changes: 2 additions & 2 deletions spec/02-integration/05-proxy/12-error_default_type_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ local HTML_TEMPLATE = [[
<html>
<head>
<meta charset="utf-8">
<title>Kong Error</title>
<title>Error</title>
</head>
<body>
<h1>Kong Error</h1>
<h1>Error</h1>
<p>%s.</p>
</body>
</html>]]
Expand Down
8 changes: 4 additions & 4 deletions t/01-pdk/08-response/13-error.t
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ Content-Type: text/html; charset=utf-8
<html>
<head>
<meta charset="utf-8">
<title>Kong Error</title>
<title>Error</title>
</head>
<body>
<h1>Kong Error</h1>
<h1>Error</h1>
<p>An invalid response was received from the upstream server.</p>
</body>
</html>
Expand Down Expand Up @@ -475,10 +475,10 @@ Content-Type: text/html; charset=utf-8
<html>
<head>
<meta charset="utf-8">
<title>Kong Error</title>
<title>Error</title>
</head>
<body>
<h1>Kong Error</h1>
<h1>Error</h1>
<p>An invalid response was received from the upstream server.</p>
</body>
</html>
Expand Down

1 comment on commit cd9ad6c

@khcp-gha-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel Build

Docker image available kong/kong:cd9ad6cad4dfd206923b16637a26f25cc98ed720
Artifacts available https://github.com/Kong/kong/actions/runs/5410711622

Please sign in to comment.