fix(session) add back regenerate strategy for kong storage (#17)

* test(*) adjust test to fail correctly

* fix(session) add back regenerate strategy

kong/plugins/session/session.lua

@@ -10,15 +10,10 @@ local _M = {}
 
 
 local function get_opts(conf)
-  local storage = conf.storage
-  if storage == "kong" then
-    storage = kong_storage
-  end
-
-  return {
+  local opts = {
     name    = conf.cookie_name,
     secret  = conf.secret,
-    storage = storage,
+    storage  = conf.storage,
     cookie  = {
       lifetime = conf.cookie_lifetime,
       idletime = conf.cookie_idletime,
@@ -31,6 +26,13 @@ local function get_opts(conf)
       discard  = conf.cookie_discard,
     }
   }
+
+  if conf.storage == "kong" then
+    opts.strategy = 'regenerate'
+    opts.storage = kong_storage
+  end
+
+  return opts
 end
 
 

spec/02-kong_storage_adapter_spec.lua

@@ -197,15 +197,20 @@ for _, strategy in helpers.each_strategy() do
         }
 
         local function send_requests(request, number, step)
+          local did_renew = false
           cookie = request.headers.cookie
 
           for _ = 1, number do
             request.headers.cookie = cookie
             res = assert(client:send(request))
             assert.response(res).has.status(200)
+            did_renew = did_renew or res.headers['Set-Cookie'] ~= nil
+
             cookie = res.headers['Set-Cookie'] or cookie
             ngx.sleep(step)
           end
+
+          return did_renew
         end
 
         -- make sure the anonymous consumer can't get in (request termination)
@@ -228,7 +233,7 @@ for _, strategy in helpers.each_strategy() do
 
         -- renewal period, make sure requests still come through and
         -- if set-cookie header comes through, attach it to subsequent requests
-        send_requests(request, 5, 0.5)
+        assert.is_true(send_requests(request, 7, 0.5))
       end)
 
       it("destroys session on logout", function()