[TypeScript] Phase 1 & 2 #3370
Merged
[TypeScript] Phase 1 & 2 #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
force-pushed
the
typescript-phase-2
branch
from
afb8ab6
to
30f9fd1
Compare
This was done by one-by-one looking at the results of the search `ts-expect-error(?= [^-])` and the replace `ts-expect-error -- TSCONVERSION` in `insomnia-app`. The idea with this convention, which we followed everywhere else, is that for Phase 3 we will either fix (and therefore remove) or remove the `-- TSCONVERSION ` part of each of these ignores.
Closed
develohpanda
approved these changes
May 12, 2021
There was a problem hiding this comment.
A list of the things I have tested:
- all request types (rest, grpc, gql)
- git integration
- cookies (rec'd from https://google.com)
- insomnia sync (sparingly)
- basic auth + query params + headers
- env variables and auto-complete
- sparingly tested debug tab
- sparingly tested test tab (lol)
- sparingly tested keyboard shortcuts
- plugins
All of these were tested while running the app in dev mode:
npm run clean
npm run bootstrap
npm run app-startThis code will under-go a period under a beta release (coming soon) and further QA in the coming weeks.
Notably, I noticed that folders are not working, however this is not a blocker for merging to develop, and the regressions identified in INS-690 (empty folder state), INS-691 (dragging into collapsed folder) and INS-688 (invalid grpc protofile error message) will each be resolved separately.
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2: #3266
Note that this stacks off of the Phase 1 PR for the reason that we'll merge both Phase 1 and 2 all at once.