Upgrade node-libcurl #2223
Merged
Upgrade node-libcurl #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for insomnia-storybook ready! Built with commit d7f10ef |
|
Deploy preview for insomnia-storybook ready! Built with commit 24b6881 |
gschier
force-pushed
the
deps/upgrade-node-libcurl
branch
from
2f6ab7c to
9737076
Compare
gschier
commented
May 27, 2020
develohpanda
approved these changes
May 27, 2020
| @@ -74,7 +73,7 @@ module.exports.start = async function(forcedVersion = null) { | |||
| await copyFiles('../app/static', '../build/static'); | |||
| await copyFiles(`../app/icons/${appConfig().appId}`, '../build/'); | |||
|
|
|||
| // Generate package.json | |||
| // Generate necessary files needed by `electron-builder` | |||
gschier
commented
May 28, 2020
| // Explicitly set userData folder from config because it's sketchy to | ||
| // rely on electron-builder to use productName, which could be changed | ||
| // by accident. | ||
| if (!isDevelopment()) { |
There was a problem hiding this comment.
I changed the product name in one of these commits without realizing electron-builder used it as the userData folder name. This adds a new option in the config and sets the userData folder explicitly so it's less likely we'll screw it up later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #2150
Test build located here: https://github.com/Kong/insomnia/releases/tag/designer%402020.1.4-alpha.1
Summary
This PR makes the following changes:
node-libcurlto latest release to prepare for Electron upgrade [Build] Update Electron #1847node-libcurlstatic prebuilt binaries so we no longer have to buildTo-Do
NPM_CONFIG_...env vars to CI because.npmrcwas being ignored in CInode-libcurlprebuilt binaries instead of building ourselveselectron-rebuilddependency.npmrcto project to tell NPM to install for Electron target instead of host OSfile://URIsfont-scannerwithfont-manager(font-scannerwas an unmaintained fork)