Upgrade libs #86
Merged
Upgrade libs #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quilicicf
force-pushed
the
master_upgradeLibs
branch
from
6916b5d to
a60d27c
Compare
|
@nijikokun Is this project still alive? |
|
Hi @quilicicf taking a look at this now <3 Thank you for submitting! |
nijikokun
reviewed
Sep 18, 2020
| '0.0.0.0', | ||
| '1.1.1.1' | ||
| ] | ||
| for: { |
There was a problem hiding this comment.
This is the only change that I think we need to address in a future PR, where we resolve back to an array of IPs
nijikokun
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I installed mockbin and saw it had a few vulnerabilities. I've done all I could to resolve them by upgrading the libs.
Two remain (from
forwarded-http&jstransformer-marked) that I can't remove from this repository, I'll try to commit to their repos if I can find the time.Don't be afraid of the amount of changes
I almost only changed lib versions. There isn't 12k editions from me 😆
A note on CI builds
I noticed the Travis builds run on outdated versions of NodeJS (0 -> 5). They should be bumped to supported versions (10 -> 13) IMO. I can edit the
.travis.ymlif it helps but I think it's not my place to decide which versions should be used.EDIT: on second thought, the tests don't run anyway because the version of NodeJS is too old. I'm gonna go for the supported versions and let you update this PR if this is not satisfactory.
A note on tests
I fixed the tests, there were two issues:
/ipsthat failed on master too but that I corrected. Please review carefullyafterphase in the cycle to close mockbin so the tests end gracefullyA note on jade
I upgraded Jade to Pug (it changed name in version 2 for copyright reasons). I successfully loaded the page
index.pugon my machine so I think I did not break anything but you may think of a better way to test this ?Security audits
The security audit went from:
To: