Modify mockbin script to use env vars or custom npm config #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
I'm proposing a modification in the
./bin/mockbin
script to read the startup params from Environment Variables or from thenpm config
properties. Now it is correct reading the customized values.Example:
If you set the port to
8001
withnpm config set mockbin:port 8001
the server will listen the 8001 instead of 8080Why ?
I was trying to use the docker image, but mockbin was not able to connect to redis instance. This happens because the
bin/mockbin
reads the config frompkg.config.*
and this properties always have the default values frompackage.json
.So I modified it to read from
process.env.npm_package_config_redis
then the custom confignpm config set mockbin:redis redis://redis:6379
will work properly.Probably fix #48