-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Lua tree generation script & patch file for Kong 3.1.0-0 Luarock #35
Conversation
Need to add support for/replace ngx.base64 (probably alias it like we did with ngx.re.match) |
|
||
local sha256_bin | ||
do | ||
local digest = require "resty.openssl.digest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This relies on ffi
and will need to be removed/replaced (see https://github.com/Kong/goks/blob/main/patches/lua-tree.patch#L68)
8d461b1
to
bfe1bf2
Compare
I'm not so sure about this after looking at how base64 us being used across the project. Why is decode_base64 imported directly but decode_base64url imports ngx.base64 first? If I update the imports to match then things work correctly. One example here
To resolve, we could fix the import in kong, or I can patch it in goks. I wrote some throwaway logic that aliases |
I moved this to draft since there's some patching or package overriding required in order to push this over. I don't have a complete list yet, the two I've noticed are the sha256 methods and patching/replacing of ngx.base64.decode_base64* methods. |
@omegabytes With 3.2.0 on the horizon I am going to close this PR in favor of grabbing the newest updates after that release occurs. |
No description provided.