Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCU-3045] Remove MacOS installation docs #5286

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[DOCU-3045] Remove MacOS installation docs #5286

merged 3 commits into from
Mar 15, 2023

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Mar 14, 2023

Description

Removing MacOS homebrew installation instructions for Kong Gateway.

  • 3.0.x - 3.2.x: topic is still there, added some info on where to go instead (docker install) and mentioned that MacOS support is coming.
  • 2.8.x and earlier: removed the topic based on analytics findings. After Sept 2022 (release of 3.0), visits to the /install-and-run/ directory (links to install topics before 3.0) dropped to nearly nothing.
    • For the MacOS topic specifically, the 2.8.x and earlier topics have been viewed 0 times since September 2022. Therefore, this topic now redirects to the latest 3.x URL with the info about upcoming packages.

Here's what the analytics look like for the past year, for the /install-and-run/ subset of URLs:
Screenshot 2023-03-14 at 9 53 08 PM

And the breakdown for specific URLs:
Screenshot 2023-03-14 at 9 53 21 PM

Our homebrew packages for Kong Gateway don't work, so there's nothing to document.
https://konghq.atlassian.net/browse/DOCU-3045

Testing instructions

Netlify link: https://deploy-preview-5286--kongdocs.netlify.app/gateway/latest/install/macos/

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Mar 14, 2023
@lena-larionova lena-larionova requested a review from a team as a code owner March 14, 2023 18:36
@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit bb8ff5d
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/641155029e6b6f000891b3c9
😎 Deploy Preview https://deploy-preview-5286--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

app/gateway-oss/2.1.x/index.md Outdated Show resolved Hide resolved
app/gateway-oss/2.1.x/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked everything over and it all looks good to me! The only thing I'm not certain about are the Vale errors. I'm not sure if they're all valid, like the ones that are wrapped in HTML tags, not sure if those would render correctly in the output or not. So I won't merge this in yet just in case there is a way to fix those.

app/gateway-oss/2.1.x/index.md Outdated Show resolved Hide resolved
app/gateway-oss/2.1.x/index.md Outdated Show resolved Hide resolved
@acgoldsmith
Copy link
Contributor

LGTM and thanks, @lena-larionova!

@acgoldsmith acgoldsmith merged commit 879b567 into main Mar 15, 2023
@acgoldsmith acgoldsmith deleted the docu-3045 branch March 15, 2023 16:28
tysoekong pushed a commit that referenced this pull request Mar 21, 2023
* remove all macos homebrew instructions and mentions; rewrite macos topics after 3.0 to link to Docker

* redirect and typo

* appease vale
StarlightIbuki pushed a commit that referenced this pull request Mar 28, 2023
* remove all macos homebrew instructions and mentions; rewrite macos topics after 3.0 to link to Docker

* redirect and typo

* appease vale
nbialostosky pushed a commit to nbialostosky/docs.konghq.com that referenced this pull request Apr 12, 2023
* remove all macos homebrew instructions and mentions; rewrite macos topics after 3.0 to link to Docker

* redirect and typo

* appease vale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants