docs(retries) document the retries setting #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theetrain
reviewed
Jun 28, 2017
app/docs/0.10.x/proxy.md
Outdated
| #### 4. Response | ||
| #### 4. Errors & retries | ||
|
|
||
| Whenever an error occurs during proxying Kong will use the underlying Nginx |
There was a problem hiding this comment.
Whenever an error occurs while proxying, Kong will use the underlying Nginx retries to pass the request onto the next upstream.
app/docs/0.10.x/proxy.md
Outdated
| See the [configuration reference][configuration-reference] for more details. | ||
|
|
||
|
|
||
| [Back to TOC](#table-of-contents) |
There was a problem hiding this comment.
Back to Table of Contents
There was a problem hiding this comment.
not changing this as this is used all over this document
p0pr0ck5
suggested changes
Jun 30, 2017
app/docs/0.10.x/proxy.md
Outdated
| #### 4. Errors & retries | ||
|
|
||
| Whenever an error occurs during while proxying, Kong will use the underlying | ||
| Nginx [retries][ngx-http-proxy-retries] to pass the request onto the next |
There was a problem hiding this comment.
"underlying Nginx mechanism"
app/docs/0.10.x/proxy.md
Outdated
|
|
||
| There are two configurable elements here: | ||
|
|
||
| 1. The number of retries. This can be configured per API using the `retries` |
There was a problem hiding this comment.
"The number of retries." is a sentance fragment. consider refactoring this to be a complete sentence
app/docs/0.10.x/proxy.md
Outdated
| server, passing a request to it, or reading the response header. | ||
|
|
||
| The second option is based on Nginx's directive | ||
| [proxy_next_upstream][proxy_next_upstream]. This option is not directly |
There was a problem hiding this comment.
"Nginx's proxy_next_upstream directive"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this also has to go to the 0.11 branch